Remove entries from History/Domain completers when they're removed on chrome. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a chrome history entry is removed, remove that entry from our history too. Same when the entire history is removed.
|
Doh! A short walk on the beach and I see how |
| @@ -169,7 +169,7 @@ class HistoryCompleter | |||
| # The domain completer is designed to match a single-word query which looks like it is a domain. This supports | |||
| # the user experience where they quickly type a partial domain, hit tab -> enter, and expect to arrive there. | |||
| class DomainCompleter | |||
| domains: null # A map of domain -> history | |||
| domains: null # A map of domain -> { entry: <historyEntry>, referenceCount: <count> } | |||
There was a problem hiding this comment.
Let's add a comment here to explain what reference count is and why it exists.
|
This is a nice case to handle, thanks for tackling it. If you can make the requested changes we'll merge it in. |
|
Thanks @philc -- I think all of your issues are addressed now. |
|
lgtm, thanks! |
philc
added a commit
that referenced
this pull request
Nov 13, 2012
Remove entries from History/Domain completers when they're removed on chrome.
davidwallacejackson
pushed a commit
to davidwallacejackson/vimium
that referenced
this pull request
Apr 3, 2014
davidwallacejackson
pushed a commit
to davidwallacejackson/vimium
that referenced
this pull request
Apr 3, 2014
Remove entries from History/Domain completers when they're removed on chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a history entry is removed in chrome (or the entire history is removed), then the effects do not propagate into vimium until the next restart.
This is a pretty inconsistent UX.
The attached code fixes this inconsistency.
(Edit: Comments regarding bug in
binarySearchdeleted.)